Fix exception handler for Notify errors in ApplicationController#3285
Open
hezzimo wants to merge 2 commits into
Open
Fix exception handler for Notify errors in ApplicationController#3285hezzimo wants to merge 2 commits into
ApplicationController#3285hezzimo wants to merge 2 commits into
Conversation
hezzimo
force-pushed
the
fix-notify-bad-request-handler
branch
5 times, most recently
from
daee2a6 to
7737865
Compare
young-rob
approved these changes
May 8, 2026
Contributor
young-rob
left a comment
young-rob
left a comment
There was a problem hiding this comment.
Looking good - worth deploying this to integration and seeing what happens when you try to submit to an invalid recipient with the team only api key
- Logic for this contradicted the comment and would surely result in exceptions being raised in non-prod environments - User (dev) friendly 'Team only key' errors would be raised in prod, not in staging or integration
hezzimo
force-pushed
the
fix-notify-bad-request-handler
branch
from
7737865 to
5216e2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully, this PR can correct the above so that we can use the team-only Notify key more effectively in Integration.
Needs manual testing in integration to ensure that we can send emails to team members.